Repository navigation
Conversation
- Copy and paste of file paths was broken on Linux, macOS, and Windows - Drag and drop of files from the OS was broken on macOS This fixes both using a similar approach to what is used in SNT, and adds extra improvements - Add a clear button to all text fields - Add a placeholder text to empty fields of SwingFileWidget with the 3 ways to populate it - Animate fields with FlatLaf's outline error border when an invalid file is dropped (These use FlatLaf's client properties, so they are safe if some other L&F is being used) Tested on macOS 27, Ubuntu 26.04, and Windows 11
- Make copy and drag-out work again as per a4927e - Duplicates: files already in the list are skipped - Folder scan: Runs in a background worker with a wait cursor and a disabled button, and results are added in one model swap. Files.walk is now closed, and UncheckedIOException is caught. Before the whole scan was running off the EDT! - Layout: - Ensure spacing consistency between the button panel and list. and Ensure the list pane fills the row height. - Apply Title case to all labels with ellipsis as needed - Apply tooltips - Buttons: Remove is disabled until something is selected, and Clear is disabled while the list is empty - Keyboard: Delete and Backspace remove the selected entries Code cleanup: remove unused services
... and transfer home-baked customizations to FlatLaf
Streamline toolbar, ensure consistent backgrounds, and sharpen UC
JDatePicker 2.0.2 is compiled for java 17 and won't work for Java 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a single fix for Drag and drop not working on macOS but snowballed into tackling a bunch of annoyances with the Swing widgets. Here is the list assembled w/ Claude from the commits:
All widgets
Text (SwingTextWidget)
File (SwingFileWidget)
File list (SwingFileListWidget)
Duplicates: files already in the list are skipped
Folder scan: Runs in a background worker with a wait cursor and a disabled button, and results are added in one model swap. Files.walk is now closed, and UncheckedIOException is caught. Before the whole scan was running off the EDT!
Layout:
Ensure spacing consistency between the button panel and list. and Ensure the list pane fills the row height.
Apply Title case to all labels with ellipsis as needed
Apply tooltips
Buttons: Remove is disabled until something is selected, and Clear is disabled while the list is empty
Keyboard: Delete and Backspace remove the selected entries
Color (SwingColorWidget)
Date (SwingDateWidget, pom.xml)
Console (TextFilterField, LoggingPanel)
Tests
SwingTextWidgetDemo is back to its original contents.
The SwingFileWidget additions were manually tested on macOS 27, Ubuntu 26.04, and Windows 11. This is how things look like: